ci(test): scope GITHUB_TOKEN to contents: read#128
Closed
arpitjain099 wants to merge 1 commit into
Closed
Conversation
The test workflow just runs `pnpm typecheck` + `pnpm test` in matrix mode. Nothing needs write access on the default GITHUB_TOKEN, so this pins it to read-only. The sibling `semgrep.yml` is already hardened. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Author
|
I have read the CLA Document and I hereby sign the CLA |
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
5665e9e to
cbee3bb
Compare
Contributor
|
I did this as part of #129. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the default
GITHUB_TOKENscope down tocontents: readfortest.yml. It only runspnpm typecheckandpnpm testin a Node matrix, with no calls to the GitHub API beyond the standard checkout.The other workflow here (
semgrep.yml) already declares its permissions. YAML validated locally.