Add workflows + second public R2 bucket#234
Open
Judyzc wants to merge 5 commits into
Open
Conversation
1917897 to
60a95a6
Compare
Judyzc
commented
Mar 30, 2026
Judyzc
commented
Mar 31, 2026
Judyzc
commented
Mar 31, 2026
… public asset domain for safe assets
…k serving existing tests
…1 and R2 calls, renamed files, checked if Cloudflare Workflow works with astro dev (hot reload) and staging
60a95a6 to
3d09426
Compare
a441d15 to
c26cf3e
Compare
joesanchezjr
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses (fixes) #209. Tested on staging.
High-level explanation of changes:
New upload flows for different environments:
Dev, AI off (default)
Dev, AI on (.dev.vars override)
Staging
Production
Follow-up
We'll need some kind of one-time script or process to move all the current R2 files that are safe into the public bucket. Right now, the code has a fallback to use D1/the Worker if the asset isn't in the public bucket. This is so the PR doesn't break any existing results/functionality when merged.
But I think ideally we'd do this process: (1) merge this PR (with fallback code) -> (2) run one-time script to move files -> (3) clean up fallback code