[C3/wrangler] Fix Angular localhost SSR blocking in development mode#12648
Merged
petebacondarwin merged 2 commits intomainfrom Feb 24, 2026
Merged
[C3/wrangler] Fix Angular localhost SSR blocking in development mode#12648petebacondarwin merged 2 commits intomainfrom
petebacondarwin merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 56920b5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude encountered an error —— View job Reviewing Changeset
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
13e024d to
dcac942
Compare
8b323ca to
087c86f
Compare
8b323ca to
13066f6
Compare
vicb
approved these changes
Feb 24, 2026
Contributor
vicb
left a comment
There was a problem hiding this comment.
LGTM
Could you please sync the PR description with the latest version of the code?
Recent Angular versions block SSR on localhost by default. Instead of modifying angular.json, this passes allowedHosts: ["localhost"] to the AngularAppEngine constructor conditionally based on process.env.NODE_ENV, which wrangler statically replaces with "development" during wrangler dev and "production" during wrangler deploy. This ensures localhost is only allowed during local development and is dead-code eliminated in production. Also unquarantines the Angular C3 e2e tests.
The ng build was stripping the NODE_ENV condition before even getting to Wrangler.
3143a02 to
56920b5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes the Angular C3 e2e tests that were quarantined due to
URL with hostname "localhost" is not allowed.errors.Recent versions of Angular's
AngularAppEngineblock serving SSR onlocalhostby default. See angular/angular-cli#32516.This PR fixes it by passing
allowedHosts: ["localhost"]to theAngularAppEngineconstructor inserver.ts:This approach is better than modifying
angular.jsonbecause:angular.jsonstructure (important for autoconfig)--configuration developmentin build scriptsIt is safe to hard code this allowed host because in Cloudflare production deployments it is never possible for localhost to hit the deployed server code.
Also unquarantines all three Angular C3 e2e tests.