Merged
Conversation
Previously example test manifests hardcoded defaults suitable for a
bosh-deployment based environment. Internally we have other environment
types that use different conventions.
This change adjusts ./scripts/deploy to more easily allow overriding
these conventions by setting environment variables. The defaults remain
aligned with the existing bosh-deployment conventions, but a caller can
now set BOSH_VAR_{network,azs,vm_type} to override the relevant
infrastructure setting.
The e2e-tests have also been updated to use the BOSH_VAR convention
rather than the bespoke and less descriptive "PXC_TEST" prefix for
discovering parameters from environment variables.
[TNZ-70251](https://vmw-jira.broadcom.net/browse/TNZ-70251)
Authored-by: Andrew Garner <andrew.garner@broadcom.com>
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
kimago
approved these changes
Dec 24, 2025
Member
kimago
left a comment
kimago
left a comment
There was a problem hiding this comment.
Changes look good, tests passing. Approving.
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously example test manifests hardcoded defaults suitable for a bosh-deployment based environment. Internally we have other environment types that use different conventions.
This change adjusts ./scripts/deploy to more easily allow overriding these conventions by setting environment variables. The defaults remain aligned with the existing bosh-deployment conventions, but a caller can now set BOSH_VAR_{network,azs,vm_type} to override the relevant infrastructure setting.
The e2e-tests have also been updated to use the BOSH_VAR convention rather than the bespoke and less descriptive "PXC_TEST" prefix for discovering parameters from environment variables.
TNZ-70251