Merged
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
kimago
force-pushed
the
feature/remove-service-config-TNZ-64710
branch
from
c1b02f5 to
895cf6a
Compare
Parse config yaml using standard go packages [TNZ-64710](https://vmw-jira.broadcom.net/browse/TNZ-64710) Authored-by: Kim Bassett <kim.bassett@broadcom.com> # Conflicts: # src/github.com/cloudfoundry-incubator/cf-mysql-cluster-health-logger/go.mod # src/github.com/cloudfoundry-incubator/cf-mysql-cluster-health-logger/go.sum
Parse config yaml using standard go packages [TNZ-64710](https://vmw-jira.broadcom.net/browse/TNZ-64710) Authored-by: Kim Bassett <kim.bassett@broadcom.com>
Parse config using standard go packages [TNZ-64710](https://vmw-jira.broadcom.net/browse/TNZ-64710) Authored-by: Kim Bassett <kim.bassett@broadcom.com>
Parse config using standard go packages [TNZ-64710](https://vmw-jira.broadcom.net/browse/TNZ-64710) Authored-by: Kim Bassett <kim.bassett@broadcom.com>
- Use yaml not json when integration tests marshal Configs - Mark some config as "yaml: omitempty" to avoid overwriting with zero values when above test-marshalled empty configs are consumed - (plus handle a nearby ignored error) [TNZ-64710](https://vmw-jira.broadcom.net/browse/TNZ-64710) Authored-by: Kim Bassett <kim.bassett@broadcom.com>
Parse config using standard go packages
- Use yaml not json when integration tests marshal test Configs. (JSON saves time.Duration as integer values not strings; new yaml libraries reject that representation) - Mark some config as "yaml: omitempty" to avoid overwriting with zero values when above test-marshalled empty configs are consumed - (plus handle a nearby ignored error) [TNZ-64710](https://vmw-jira.broadcom.net/browse/TNZ-64710) Authored-by: Kim Bassett <kim.bassett@broadcom.com>
kimago
force-pushed
the
feature/remove-service-config-TNZ-64710
branch
from
895cf6a to
458c65e
Compare
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
Member
|
I'll merge once the pipeline is clear and green. Currently validating dependency bump merges from this morning. |
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes use of non-maintained service-config library for config parsing
https://vmw-jira.broadcom.net/browse/TNZ-64710