Conversation
|
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Yay, this is great! I didn't review the code but in terms of functionality I think this is great (and honestly would be fine adding this as a feature as-is while we fine-tune it.)
I do wonder if there's an opportunity to add some character to the
I wondered the same things. I think both options are worth exploring.
I wondered about this as well. I think the container is fun but I'm not sure I'd always want it. Maybe it should be an optional style on large screens? Or maybe we do a different treatment all the time like you mentioned. Other random thoughts:
Thanks for working on this Tyler! |
Overview
A little prototype with some controls to experiment with a potential floating sidebar design, which @Paul-Hebert suggested in #2148.
This isn't intended to be merged, just to share a deploy preview for reference and discussion.
Screenshots
On small screens, the side does not look much different from a paragraph with a silver background:
I set its
font-sizeto be one step down in our modular scale, but it felt really small to me, so I used amaxfunction to only do so up to a minimum of16px. I'm open to feedback on this.I wondered if it might feel less intrusive sometimes to use
<details>and<summary>, so I added a control for specifying a summary:Is that too boring looking? I'm not sure.
At very wide sizes, I use some absolute positioning and a lot of
calcto nestle the side note into the margins. I also use a radial gradient to fake an inverted rounded corner, because I thought it felt a bit disconnected from its point in the article. (I mean, it's still a lot more disconnected from the original footnote, but this way I think it's clear that it comes between two paragraphs.)Like @Paul-Hebert's site, I added a modifier to allow the aside to align the opposite way:
The
<details>version would work the same way at large sizes:Gosh, that version is missing something. Does it need a rule between the summary and details? Should the summary be a medium weight? I'm not sure.
I'm also wondering now if the container is too confining on large screens. Maybe a border to the left or right would work? Might be worth trying and comparing.
Testing
Try it out for yourself. I've not tested it outside of Arc (Chromium).