Skip to content

chore: Always use VR for dry-run builds#108

Open
pan-kot wants to merge 6 commits intomainfrom
always-vr-build
Open

chore: Always use VR for dry-run builds#108
pan-kot wants to merge 6 commits intomainfrom
always-vr-build

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Feb 13, 2026

This PR addresses an issue when the component package was built with Classic theme when in dry-run (a dependency of board-components, chart-components and other packages). This already led to hard to find errors where a particular integration test would pass in one repository but then fail in another one when in dry-run action.

I tested the change the following way:

  • Created a PR in components pointing to this branch in actions;
  • Add a code that threw an error when not in visual refresh;
  • Confirmed that downstream packages (like board components) tests passed (those were failing when doing the same exercise but w/o changes to actions);
  • Confirmed that components package own unit and integ tests passed (those do not use ALWAYS_VISUAL_REFRESH flag).

Rel: AWSUI-61173

Follow-up change: cloudscape-design/components#4250

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot marked this pull request as ready for review February 13, 2026 17:09
@pan-kot pan-kot requested a review from a team as a code owner February 13, 2026 17:09
@pan-kot pan-kot requested review from ernst-dev and removed request for a team February 13, 2026 17:09
@pan-kot pan-kot enabled auto-merge (squash) February 13, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant