chore: Using prepare package lock script from build tools#155
Conversation
pan-kot
force-pushed
the
use-prepare-package-lock-from-build-tools
branch
3 times, most recently
from
98fd484 to
b9693b5
Compare
| "//": "ensure that typedoc uses latest typescript. It prints a warning, but works", | ||
| "overrides": { | ||
| "typescript": "^4.9.4", | ||
| "typescript": "^5.9.2", |
There was a problem hiding this comment.
This matches the version of TS used in the main components package. It fixes a compilation error with test-utils, present after upgrading the deps.
| { | ||
| "inlineType": { | ||
| "name": "NonCancelableEventHandler<{}>", | ||
| "name": "NonCancelableEventHandler", |
There was a problem hiding this comment.
This is caused by TS version upgrade.
| "tsBuildInfoFile": "./.cache/e2e-tests.tsbuildinfo" | ||
| }, | ||
| "include": ["types", "test"], | ||
| "include": ["types", "test", "vite/client"], |
There was a problem hiding this comment.
This fixes import.meta.glob call in visual tests. W/o these types, the call to .glob fails.
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| /* eslint-disable @vitest/no-conditional-expect */ |
There was a problem hiding this comment.
This rule was added to recommended configs, see: vitest-dev/eslint-plugin-vitest@bc95b10#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R106
There was a problem hiding this comment.
Do we want to make the disable more local to the relevant tests? Or do we not want to apply this rule in general for some reason (in that case could we instead disable it globally via configuration)?
There was a problem hiding this comment.
I think a global config makes sense here. That rule was not required in the prev configuration, and in this particular case I do not see clear ways to refactor the code to comply. I will update the PR.
| }; | ||
|
|
||
| options.series?.forEach((series) => { | ||
| if (!("type" in series)) { |
There was a problem hiding this comment.
The Highcharts series option type was extended with UnknownSeriesOptionsType, which does not include the type field.
pan-kot
force-pushed
the
use-prepare-package-lock-from-build-tools
branch
from
b9693b5 to
c94699b
Compare
2 participants
Description
Using prepare package lock from here: https://github.com/cloudscape-design/build-tools/blob/main/package.json#L7
Related:
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.