refactor: memoize highlight result to avoid redundant tokenization#108
Merged
SpyZzey merged 1 commit intocloudscape-design:mainfrom Jan 28, 2026
Merged
Conversation
The highlight function performs expensive tokenization on every render, even when content hasn't changed. This adds useMemo to cache the result based on content and highlight function, preventing unnecessary re-tokenization during parent re-renders, dark mode toggles, or action button interactions.
SpyZzey
approved these changes
Jan 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 29 29
Lines 281 281
Branches 34 34
=======================================
Hits 279 279
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
cloudscape-design:main
with commit Jan 28, 2026
adfba14
48 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
useMemoto cache the syntax highlighting result in the CodeView component, preventing expensive re-tokenization on every render.Problem
The
highlightfunction (which uses ace-code's tokenizer) runs on every render ofInternalCodeView, even whencontenthasn't changed. This is wasteful because:Solution
Wrap the highlight call in
useMemowith[content, highlight]as dependencies:Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.