refactor: minor cleanups#111
Merged
gethinwebster merged 1 commit intocloudscape-design:mainfrom Jan 26, 2026
Merged
Conversation
- Hoist regionProps objects to module-level constants to avoid recreation on every render - Remove redundant optional chaining in highlight/index.tsx where token.className is already checked in the ternary condition
gethinwebster
approved these changes
Jan 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 99.28% 99.29%
=======================================
Files 29 29
Lines 281 284 +3
Branches 34 33 -1
=======================================
+ Hits 279 282 +3
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
cloudscape-design:main
with commit Jan 26, 2026
5cea9fa
45 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR applies some minor code streamlining:
highlight/index.tsxwheretoken.classNameis already checked in the ternary conditionHow has this been tested?
I've run the server and confirmed that the demos render as expected.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.