chore: Tolerate matchMedia returning null#4028
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4028 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 861 861
Lines 25214 25213 -1
Branches 9094 9094
=======================================
Hits 24456 24456
+ Misses 711 710 -1
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4badb7 to
eeb4361
Compare
pan-kot
approved these changes
Nov 17, 2025
jperals
added a commit
that referenced
this pull request
Nov 18, 2025
ngynmt
pushed a commit
to ngynmt/components
that referenced
this pull request
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for
matchMediashould be more than good enough (MDN docs), but it is returningnullsometimes for some team's canaries, causing operational pain.See
AWSUI-61447.Aiming to refactor by moving
useMobileinto component-toolkit (cloudscape-design/component-toolkit#173, cloudscape-design/component-toolkit#174), but that is taking longer, so I will do that on the side and expedite this fix in this form first.How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.