feat: add folder upload support to FileInput and FileDropzone#4207
Open
kevingomes17 wants to merge 1 commit intocloudscape-design:mainfrom
Open
feat: add folder upload support to FileInput and FileDropzone#4207kevingomes17 wants to merge 1 commit intocloudscape-design:mainfrom
kevingomes17 wants to merge 1 commit intocloudscape-design:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4207 +/- ##
==========================================
- Coverage 97.19% 96.85% -0.34%
==========================================
Files 886 888 +2
Lines 26008 26136 +128
Branches 9421 9456 +35
==========================================
+ Hits 25278 25314 +36
- Misses 724 769 +45
- Partials 6 53 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b67691d to
d6e3626
Compare
Member
|
Hey @kevingomes17 this looks good, just make sure to add more test coverage (you can see a summary from codecov) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds folder upload support to the FileInput and FileDropzone components, enabling users to select and upload entire folders of files.
Key changes:
FileInput Component:
FileDropzone Component:
Shared Utilities:
accept-filter.tswith file type filtering functions supporting extensions (.jpg, .png) and MIME types (image/*)folder-traversal.tswith async folder traversal utilitiesType Declarations:
global.d.ts
Related links, issue #, if available: https://quip-amazon.com/0y0pAIzFG0mD/Folder-support-for-file-input-Tech-design
How has this been tested?
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.