Skip to content

refactor: rename dropdownContentRole to ariaRole #4248

Draft
mxschll wants to merge 35 commits intomainfrom
dev-v3-schomax-dropdown-aria
Draft

refactor: rename dropdownContentRole to ariaRole #4248
mxschll wants to merge 35 commits intomainfrom
dev-v3-schomax-dropdown-aria

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Feb 12, 2026

Description

This PR refactors the dropdownContentRole prop of the Dropdown component to be named ariaRole, aligning its API with other components such as Flashbar.

Related

[Quip proposal: RGJgABPXohP8RGJgABPXohP8]

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Also moves maxWidth behavior if expandToViewport=true to the
respective components, as this is a "feature" we want to keep
for backward compatibility but it's not intended to be a part
of the dropdown component.
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (9fc78ce) to head (6adf268).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4248      +/-   ##
==========================================
+ Coverage   97.19%   97.24%   +0.04%     
==========================================
  Files         886      886              
  Lines       26021    26040      +19     
  Branches     9433     9435       +2     
==========================================
+ Hits        25291    25322      +31     
+ Misses        724      712      -12     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant