Skip to content

feat: Release renderOption for all systems#4532

Merged
gethinwebster merged 1 commit into
mainfrom
feat/release-render-option-all-systems
May 21, 2026
Merged

feat: Release renderOption for all systems#4532
gethinwebster merged 1 commit into
mainfrom
feat/release-render-option-all-systems

Conversation

@gethinwebster
Copy link
Copy Markdown
Member

@gethinwebster gethinwebster commented May 18, 2026

Description

Remove @awsuiSystem core annotation from renderOption on select, autosuggest, and multiselect components, making custom option rendering available to all systems (including console).

This follows the same approach as button-dropdown renderItem (PR #4453). The component retains full control of accessibility (ARIA roles, keyboard navigation) regardless of custom rendering.

Related links, issue #, if available: n/a

How has this been tested?

  • TypeScript compilation passes with no new errors
  • Documenter snapshots updated
  • Existing unit and integration tests unaffected (annotation removal only)
Review checklist

Correctness

  • Changes are backward-compatible — only removes a system gate, no API changes.
  • No new browser features used.
  • No accessibility impact — components retain full ARIA/keyboard management regardless of custom rendering.

Security

  • No URL handling changes.

Testing

  • Existing tests cover renderOption functionality (already tested in core system).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Remove @awsuiSystem core annotation from renderOption on select,
autosuggest, and multiselect components, making custom option
rendering available to all systems (including console).
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.42%. Comparing base (33b7cf8) to head (906d32f).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4532   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         936      936           
  Lines       29626    29626           
  Branches    10764    10764           
=======================================
  Hits        28864    28864           
  Misses        755      755           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gethinwebster gethinwebster marked this pull request as ready for review May 21, 2026 07:24
@gethinwebster gethinwebster requested a review from a team as a code owner May 21, 2026 07:24
@gethinwebster gethinwebster requested review from NathanZlion and removed request for a team May 21, 2026 07:24
@gethinwebster gethinwebster added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 8e0a88e May 21, 2026
52 checks passed
@gethinwebster gethinwebster deleted the feat/release-render-option-all-systems branch May 21, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants