feat: add one theme style dictionary#4549
Open
mxschll wants to merge 8 commits into
Open
Conversation
mxschll
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4549 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 938 938
Lines 29647 29647
Branches 10774 10774
=======================================
Hits 28884 28884
Misses 756 756
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mxschll
commented
May 22, 2026
|
|
||
| // Anything not listed here falls back to the visual-refresh value via ThemeBuilder.addTokens in ./index.ts. | ||
| const tokens: StyleDictionary.ColorsDictionary = { | ||
| colorBackgroundButtonPrimaryDefault: '{colorBlack}', |
Member
Author
There was a problem hiding this comment.
Subsequent PRs will fill this dictionary.
mxschll
commented
May 22, 2026
| window.location.reload(); | ||
| }; | ||
| vrSwitchProps.checked = urlParams.visualRefresh && !urlParams.oneTheme; | ||
| vrSwitchProps.onChange = event => activateTheme(event.target.checked ? 'visualRefresh' : 'classic'); |
Member
Author
There was a problem hiding this comment.
Same behavior as before: un-toggling visual refresh falls back to classic.
mxschll
commented
May 22, 2026
| id="one-theme-toggle" | ||
| type="checkbox" | ||
| checked={urlParams.oneTheme} | ||
| onChange={event => activateTheme(event.target.checked ? 'oneTheme' : 'classic')} |
Member
Author
There was a problem hiding this comment.
Similar behavior as with visual refresh: un-toggling falls back to classic.
mxschll
force-pushed
the
dev-v3-onetheme-dict
branch
from
6e4eb82 to
20479ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds One Theme as a overlay on visual-refresh, gated behind
INCLUDE_ONE_THEME=true. Set on dev scripts, not on build, so published packages don't include it. Dev page theme switcher has a new toggle for local testing.Related links, issue #, if available:
aQokArCTx9abHow has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.