Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 96.30% 97.38% +1.07%
==========================================
Files 46 46
Lines 2163 2138 -25
Branches 406 403 -3
==========================================
- Hits 2083 2082 -1
+ Misses 79 56 -23
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
just-boris
commented
Feb 1, 2025
| "lint-staged": "^12.5.0", | ||
| "loader-utils": "^3.2.1", | ||
| "lodash": "^4.17.21", | ||
| "merge": "^2.1.1", |
Member
Author
There was a problem hiding this comment.
Found an unused dependency while doing it
just-boris
commented
Feb 1, 2025
Comment on lines
20
to
29
| '.': { | ||
| import: './build/index.js', | ||
| require: './build/index.cjs', | ||
| }, | ||
| './internal': { | ||
| import: './build/internal.js', | ||
| require: './build/internal.cjs', | ||
| }, |
Member
Author
There was a problem hiding this comment.
Compatibility for require() use-case is still supported
just-boris
commented
Feb 1, 2025
src/build/index.cjs
Outdated
Comment on lines
1
to
4
| const buildThemedComponents = async (...args) => { | ||
| const esmAPI = await import('./index.js'); | ||
| return esmAPI.buildThemedComponents(...args); | ||
| }; |
Member
Author
There was a problem hiding this comment.
Thanks to webdriverio for this idea how to support compatibility without code duplication:
just-boris
force-pushed
the
verbatim-modules
branch
from
1e288ab to
99a7500
Compare
just-boris
force-pushed
the
verbatim-modules
branch
from
99a7500 to
05f592a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Notes
make this package a proper ESM module
type: "module"(which requires.jsextension everywhere)isolatedModulesandverbatimModuleSyntax(requireimport typefor all type imports)Testing
Dry-runs: 7218081746, 7218084211
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.