fix: generate dark mode overrides for tokens referencing other tokens#132
Open
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Open
fix: generate dark mode overrides for tokens referencing other tokens#132TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Conversation
The resolveToken function was returning CSS variables for any token that existed in propertiesMap, including regular token-to-token references like colorBackgroundTableHeader → colorBackgroundContainerHeader. This caused both light and dark modes to resolve to the same CSS variable string (e.g., var(--color-background-container-header)), so the difference() function couldn't detect any difference between modes and didn't generate dark mode overrides. The fix restricts CSS variable resolution to only reference tokens (palette tokens like colorPrimary500) by using isReferenceToken() instead of checking token existence. This allows regular token references to continue resolving recursively to their actual values, enabling proper light/dark mode comparison and override generation.
TrevorBurnham
requested review from
ernst-dev
and removed request for
a team
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cloudscape-design/components#4111
#130 introduced a bug where the
resolveTokenfunction returned CSS variables for any token that existed inpropertiesMap, including regular token-to-token references likecolorBackgroundTableHeader→colorBackgroundContainerHeader. This caused both light and dark modes to resolve to the same CSS variable string (e.g.,var(--color-background-container-header)), so thedifference()function couldn't detect any difference between modes and didn't generate dark mode overrides.The fix restricts CSS variable resolution to only reference tokens (palette tokens like
colorPrimary500) by usingisReferenceToken()instead of checking token existence. This allows regular token references to continue resolving recursively to their actual values, enabling proper light/dark mode comparison and override generation.cc @jkuelz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.