Conversation
|
|
||
|
|
||
|
|
||
| # Project setup |
There was a problem hiding this comment.
We need to be very careful about the main readme, where we try to be compact and only include information for users of this package.
The new lines need not be surfaced to users I assume. For python installation, users will use pip install spanner-graph-notebook. This package is on PyPi.
For frontend development, I believe the readme is in frontend already?
frontend/src/graph-server.js
Outdated
| getPing: '/get_ping', | ||
| postQuery: '/post_query', | ||
| postNodeExpansion: '/post_node_expansion', | ||
| // saveConfig: '/save_config', |
There was a problem hiding this comment.
do we still need these? maybe proofread before sending out?
frontend/static/constent.js
Outdated
There was a problem hiding this comment.
empty file. maybe proofread the PR first in the future?
spanner_graphs/magics.py
Outdated
|
|
||
| singleton_server_thread: Thread = None | ||
|
|
||
| SHOW_LOADER = """ |
There was a problem hiding this comment.
make this an individual html file instead of inline in python? this is a bit hacky and hard to manage.
There was a problem hiding this comment.
can we test the new %spanner_graph somewhere in the test?
spanner_graphs/magics.py
Outdated
| ) | ||
| display(HTML(html_content)) | ||
|
|
||
| @cell_magic |
There was a problem hiding this comment.
I think we need to use line_cell_magic so that this can be invoked in a 1-liner like %spanner_graph only.
frontend/static/jupyter.html
Outdated
| params: `{{ params }}`, | ||
| query: `{{ query }}`, | ||
| (function() { | ||
| const gcpData_{{ id }} = {{ gcp_data | safe }}; |
There was a problem hiding this comment.
avoid placing bulk JS code in html, let's make it modularized in the TS/JS modules.
2 participants
No description provided.