Round score at subtask level#1690
Merged
veluca93 merged 1 commit intocms-dev:mainfrom May 1, 2026
Merged
Conversation
…d scores instead of unrounded ones.
Contributor
Author
|
FYI, @veluca93 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
- Coverage 54.17% 54.16% -0.02%
==========================================
Files 340 340
Lines 27844 27835 -9
==========================================
- Hits 15085 15077 -8
+ Misses 12759 12758 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
veluca93
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates scoring to match the updated IOI rule: each subtask score is rounded to the task’s score_precision, and the final task score is computed as the sum of those rounded subtask scores (with a final rounding pass to avoid float artifacts).
It also allows us to avoid passing unrounded score around. I am keeping some rounding in ranking in case of float issues.