Open
Conversation
Collaborator
|
Are we good to merge ? |
Collaborator
|
I'd prefer someone tests this before merging first. |
|
Either vinay or I can try to test this, but it would be good to know a couple of things: (1) is the recipe in the read me up-to-date? (2) what should be tested? The main commit is pretty large, so I am not sure, if anything, to focus on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By merging this pull request, the codes for scanning the met filters' performances and also two scripts for plotting the results, will be added.
The added codes and scripts are taken from this repository but with some small modifications in order to be supported in
CMSSWenvironment.