-
Notifications
You must be signed in to change notification settings - Fork 673
Adding security self-assesment for project K3s #1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Orlix <orlin@orlix.org>
|
@eddie-knight PTAL ^^ Thanks! |
|
FYI: The contents of the assessment were reviewed and approved from the prior PR. cncf/tag-security#1500 (review) |
|
@eddie-knight @JustinCappos is there anything else we need to get this in? thank you! |
|
@OrlinVasilev This is approved by the TAG, but must be merged by the TOC per the codeowner enforcement |
|
Thank you! |
@mnm678 @jkjell @evankanderson , can you help us move this along? |
|
If we move the assessment to a sub-directory called https://github.com/cncf/toc/blob/main/.github/CODEOWNERS#L40 |
kfaseela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just left a few small nits. Otherwise LGTM
|
|
||
| This document provides K3s maintainers and stakeholders with additional context to help inform the roadmap creation process, so that security and feature improvements can be prioritized accordingly. | ||
|
|
||
| ## Security functions and features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RBAC and Pod Security Admission are correctly identified as critical security functions. Per the TAG Security self-assessment guidance, these could optionally be framed more explicitly in threat-modeling terms (e.g., threats mitigated such as unauthorized access or privilege escalation), not mandatory - just a suggestion.
Co-authored-by: Faseela K <k.faseela@gmail.com> Signed-off-by: Orlix <7236111+OrlinVasilev@users.noreply.github.com>
Co-authored-by: Faseela K <k.faseela@gmail.com> Signed-off-by: Orlix <7236111+OrlinVasilev@users.noreply.github.com>
Co-authored-by: Faseela K <k.faseela@gmail.com> Signed-off-by: Orlix <7236111+OrlinVasilev@users.noreply.github.com>
Co-authored-by: Faseela K <k.faseela@gmail.com> Signed-off-by: Orlix <7236111+OrlinVasilev@users.noreply.github.com>
Co-authored-by: Faseela K <k.faseela@gmail.com> Signed-off-by: Orlix <7236111+OrlinVasilev@users.noreply.github.com>
Adding the K3s security self-assesment as advised by @eddie-knight cncf/tag-security#1500 (comment)