ci: declare workflow-level contents: read on 8 e2e/test workflows#1148
Open
arpitjain099 wants to merge 1 commit into
Open
ci: declare workflow-level contents: read on 8 e2e/test workflows#1148arpitjain099 wants to merge 1 commit into
contents: read on 8 e2e/test workflows#1148arpitjain099 wants to merge 1 commit into
Conversation
Pins the default GITHUB_TOKEN to contents: read on the 8 workflows in .github/workflows/ that don't actually need any write scope: - e2e-kind-create.yaml, e2e-kind-decommission.yaml, e2e-kind-upgrades.yaml, e2e-kind-upgradessha256.yaml, e2e-kind-versionchecker.yaml: kind cluster e2e suites. - nightly-smoketest.yaml: scheduled smoke test. - templates.yaml: template-generation check, no GitHub API. - tests.yaml: unit/integration test matrix. update-crdb-versions.yaml is intentionally left out; it uses peter-evans/create-pull-request which needs contents: write + pull-requests: write. That scope is best declared by maintainers. Motivation: CVE-2025-30066 (March 2025 tj-actions/changed-files compromise) exfiltrated GITHUB_TOKEN from workflow logs. Per-workflow caps bound runtime authority irrespective of repo or org default, give drift protection if the default ever widens, and are credited per-file by the OpenSSF Scorecard Token-Permissions check. YAML validated locally with yaml.safe_load. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENtocontents: readon the 8 workflows in.github/workflows/that don't actually need any write scope:e2e-kind-create.yaml,e2e-kind-decommission.yaml,e2e-kind-upgrades.yaml,e2e-kind-upgradessha256.yaml,e2e-kind-versionchecker.yaml: kind cluster e2e suites.nightly-smoketest.yaml: scheduled smoke test.templates.yaml: template-generation check.tests.yaml: unit and integration test matrix.None of the eight calls a GitHub API beyond the initial checkout, so workflow-level
contents: readis sufficient.update-crdb-versions.yamlis intentionally left out. It usespeter-evans/create-pull-requestwhich needscontents: write+pull-requests: write. That scope is best declared by maintainers who own the version-bump flow.Why
CVE-2025-30066 (March 2025
tj-actions/changed-filessupply-chain compromise) exfiltratedGITHUB_TOKENfrom workflow logs and the leaked token retained whatever scope was issued at the workflow level. Pinning per workflow caps that runtime authority irrespective of the repo or org default, gives drift protection if the default ever widens, and is credited per-file by the OpenSSF ScorecardToken-Permissionscheck.YAML validated locally with
yaml.safe_loadon each touched file.