Open
Conversation
Contributor
Until the RiiR [project](https://github.com/ansuz/RIIR) is globally complete, fetching Rust infra will not be completely reliable. For our purposes, the `curl` for rust installation can fail silently and the pipeline proceeds. This change adds a fetch and check which trips a retry in the pipeline. Epic: none Fixes: cockroachdb#167098 Release note: None
Member
|
This change is |
bghal
force-pushed
the
oncall-rust-postgres
branch
from
c846108 to
14d3696
Compare
fqazi
approved these changes
Apr 2, 2026
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 3 files and all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on bghal).
Contributor
Author
|
/trunk merge |
rafiss
requested changes
Apr 3, 2026
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
CI needs to pass before this will enter the Trunk queue. i also had some comments
@rafiss made 3 comments.
Reviewable status:
pkg/cmd/roachtest/tests/rust_postgres.go line 82 at r1 (raw file):
node, "install and verify rust and cargo", `bash -o pipefail -c 'curl https://sh.rustup.rs -sSf | sh -s -- -y && /home/ubuntu/.cargo/bin/cargo --version'`,
nit: let's not hardcode /home/ubuntu/. use $HOME/.cargo/bin/cargo
pkg/cmd/roachtest/tests/rust_sqlx.go line 96 at r1 (raw file):
ctx, t, c, node, "install and verify rust and cargo", `bash -o pipefail -c 'curl https://sh.rustup.rs -sSf | sh -s -- -y && /home/ubuntu/.cargo/bin/cargo --version'`,
nit: let's not hardcode /home/ubuntu/. use $HOME/.cargo/bin/cargo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until the RiiR
project is
globally complete, fetching Rust infra will not be
completely reliable.
For our purposes, the
curlfor rust installationcan fail silently and the pipeline proceeds. This
change adds a fetch and check which trips a retry
in the pipeline.
Epic: none
Fixes: #167098
Release note: None