sql: fix comments and error handling in temp schema cleanup#167441
Open
rafiss wants to merge 1 commit intocockroachdb:masterfrom
Open
sql: fix comments and error handling in temp schema cleanup#167441rafiss wants to merge 1 commit intocockroachdb:masterfrom
rafiss wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Add a few cleanups to follow onto cockroachdb#166915: - Fix `tblDescsByID` field comment which incorrectly said "maps sequence IDs" when it actually maps all object IDs. - Propagate the error from `ForEachDescriptor` instead of discarding it. - Restore the removed comment explaining why only unowned sequences are explicitly dropped (owned ones are dropped via CASCADE). - Add comment explaining why `IF EXISTS` is needed in DROP statements. - Handle `ErrDescriptorNotFound` in `cleanupTempSequenceDeps` when a dependent permanent table is dropped between Phase 1 and Phase 2, treating it as a no-op instead of triggering expensive retry loops. - Fix two stale "preHook" references in test comments. Informs: cockroachdb#166915 Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few cleanups to follow onto #166915:
tblDescsByIDfield comment which incorrectly said "maps sequence IDs" when it actually maps all object IDs.ForEachDescriptorinstead of discarding it.IF EXISTSis needed in DROP statements.ErrDescriptorNotFoundincleanupTempSequenceDepswhen a dependent permanent table is dropped between Phase 1 and Phase 2, treating it as a no-op instead of triggering retry loops.Informs: #166815
Release note: None