sql: block survival goal and primary region changes during RBR transitions#167475
Draft
shghasemi wants to merge 1 commit intocockroachdb:masterfrom
Draft
sql: block survival goal and primary region changes during RBR transitions#167475shghasemi wants to merge 1 commit intocockroachdb:masterfrom
shghasemi wants to merge 1 commit intocockroachdb:masterfrom
Conversation
…tions Previously, ALTER DATABASE SURVIVE and ALTER DATABASE PRIMARY REGION did not check for in-flight REGIONAL BY ROW transitions on tables in the database. This could cause a race where the async locality change changer reads a stale survival goal and writes partition zone configs with incorrect NumReplicas, leading to zone config validation failures. Fixes cockroachdb#167454 Release note: None
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ALTER DATABASE SURVIVE and ALTER DATABASE PRIMARY REGION did not check for in-flight REGIONAL BY ROW transitions on tables in the database. This could cause a race where the async locality change changer reads a stale survival goal and writes partition zone configs with incorrect NumReplicas, leading to zone config validation failures.
Fixes #167454
Release note: None