build(deps-dev): bump phpunit/phpunit from 9.5.28 to 13.1.9#358
build(deps-dev): bump phpunit/phpunit from 9.5.28 to 13.1.9#358dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.5.28 to 13.1.9. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/13.1.9/ChangeLog-13.1.md) - [Commits](sebastianbergmann/phpunit@9.5.28...13.1.9) --- updated-dependencies: - dependency-name: phpunit/phpunit dependency-version: 13.1.9 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR performs a significant upgrade across four major versions of PHPUnit (9 to 13). This change introduces critical breaking requirements that are currently unaddressed in the PR, most notably a hard requirement for PHP 8.4.1+ and the need for a configuration migration.
The test suite is likely to fail in its current state because the mandatory migration of phpunit.xml and the update of lifecycle methods (requiring void return types) have not been performed. Furthermore, the upgrade of nikic/php-parser to v5 may introduce upstream incompatibilities with metrics tools used in this project.
About this PR
- The upgrade to PHPUnit 10+ requires a specific migration for the
phpunit.xmlconfiguration file and a transition to PHP 8 Attributes for test metadata. These changes are missing from the current PR.
Test suggestions
- Execute the test suite with PHPUnit 13 to verify compatibility with removed assertions and internal API changes
- Verify that
phpunit.xmlhas been migrated to the new schema introduced in PHPUnit 10 - Verify that the CI environment is updated to support PHP 8.4.1+, as required by the new dependency versions
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Execute the test suite with PHPUnit 13 to verify compatibility with removed assertions and internal API changes
2. Verify that `phpunit.xml` has been migrated to the new schema introduced in PHPUnit 10
3. Verify that the CI environment is updated to support PHP 8.4.1+, as required by the new dependency versions
Low confidence findings
- The jump of
nikic/php-parserfrom v4 to v5 may cause issues withcodacy/codacy-metrics-pdependif its underlying dependencies are not yet compatible with the v5 parser API.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^9.0", | ||
| "phpunit/phpunit": "^13.1", |
There was a problem hiding this comment.
🔴 HIGH RISK
This upgrade to PHPUnit 13 introduces a hard requirement for PHP 8.4.1 or higher, which is a breaking change for development and CI environments. Additionally, jumping from version 9 to 13 involves numerous breaking changes—including the transition to attributes for test metadata, mandatory void return types for lifecycle methods, and a new configuration schema—that are incompatible with the existing test suite and phpunit.xml.
To address this:
- Update the
phpunit.xmlconfiguration file to the latest schema by runningvendor/bin/phpunit --migrate-configuration. - Convert PHPUnit DocBlock annotations (such as
@test,@dataProvider, and@depends) into their equivalent PHP 8 Attributes. - Ensure CI environments are updated to PHP 8.4.1+.
Bumps phpunit/phpunit from 9.5.28 to 13.1.9.
Release notes
Sourced from phpunit/phpunit's releases.
... (truncated)
Changelog
Sourced from phpunit/phpunit's changelog.
... (truncated)
Commits
506033fPrepare releasec8041c1Merge branch '12.5' into 13.1792c298Prepare release3c6867aMerge branch '12.5' into 13.1e5120fdMerge branch '11.5' into 12.51e58f6dMerge branch '10.5' into 11.58be7939Merge branch '9.6' into 10.5505691bMerge branch '8.5' into 9.6b5c83ceHarden against script injectioncbbd4d9Do not persist Git credentialsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)