[0.22] Add InstructionLinkNode, InstructionAccountLinkNode and InstructionArgumentLinkNode#183
Merged
lorisleiva merged 11 commits intomainfrom Aug 21, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: f2a68b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lorisleiva
changed the title
InstructionLinkNode, InstructionAccountLinkNode and InstructionArgumentLinkNodeInstructionLinkNode, InstructionAccountLinkNode and InstructionArgumentLinkNode
etodanik
approved these changes
Aug 21, 2024
Contributor
etodanik
left a comment
etodanik
left a comment
There was a problem hiding this comment.
This is wonderful ! LVGTM
Can't wait to rebase my bundles PR on top of this.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce 3 new types of
LinkNodesin order to references instructions and their accounts/arguments in various parts of the tree.This PR helps prepares for #143 which create instruction bundles by pointing to other instructions and overrides their inputs by pointing to their accounts/arguments.
Additionally, I'm hoping the
AccountValueNodeandArgumentValueNodecan be replaced by the newInstructionAccountLinkNodeandInstructionArgumentLinkNoderespectively which would make linking within the Kinobi IDL more consistent.