refactor: extract fs and path helpers into runtime-utils#971
Open
JkrishnaD wants to merge 4 commits intocodama-idl:mainfrom
Open
refactor: extract fs and path helpers into runtime-utils#971JkrishnaD wants to merge 4 commits intocodama-idl:mainfrom
JkrishnaD wants to merge 4 commits intocodama-idl:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 05b2684 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
@lorisleiva have a look into this and let me know if there is any requirement for the changes |
Member
|
Hi there, thanks for this. However, I can see a few issues by just running the code with my eyes though:
This is giving me AI slop vibes. Please review your own code thoroughly before publishing and ensure all tests are passing locally. |
Author
|
hey @lorisleiva
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the filesystem and path helpers previously located in
@codama/renderers-coreinto a new shared package:
@codama/runtime-utils.The goal is to centralize runtime-specific interactions (e.g.
node:fs,node:path) in adedicated package so that Codama packages — including renderers — can be imported safely in
non-Node environments.
What changed
@codama/runtime-utilspackagefsandpathhelpers into this package without changing behaviorrenderers-coreto consume the new shared helpersNotes
Closes #67