Refactor renderVisitor to use crateFolder as primary argument#85
Open
lorisleiva wants to merge 1 commit into12-01-sync_cargo.toml_when_generating_codefrom
Conversation
🦋 Changeset detectedLatest commit: e486ba1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3825d48 to
e486ba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR refactors
renderVisitorto accept the crate folder (whereCargo.tomllives) as its primary argument, instead of the generated output path. The generated folder is now derived internally by joining the crate folder with a configurablegeneratedFolderoption (defaults to'src/generated').This mirrors the same refactoring done in renderers-js#118, with the difference that
syncCargoTomlremainsfalseby default since it hasn't been tested in production yet.This also fixes
formatCodeandsyncCargoTomlwhich previously required an optionalcrateFolderoption — now that the crate folder is always known, these features work without additional configuration.