Mirror generated dancer sprites #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
breville
reviewed
Oct 28, 2025
src/GeneratedDancer.js
Outdated
Comment on lines
43
to
44
| this.shouldMirror = 1; | ||
| this.mirror = 1; |
Member
There was a problem hiding this comment.
Could these be true instead of 1?
Contributor
Author
There was a problem hiding this comment.
I used -1 | 1 to align to p5.play: https://code-dot-org.github.io/p5.play/docs/files/lib_p5.play.js.html
.mirror needs to stay that way but .shouldMirror could change to a boolean easily enough.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
This adds a way for generated dancer sprites to effectively mirror dance moves when needed. The
GeneratedDancerlayer will now manage amirrorproperty that gets updated during the sprite'supdateSpriteFrameloop. When the animation has finished, we flip themirrorvalue. p5 handles the rest. This is only needed for dance moves that require mirroring.With this change, generated dancers will be able to follow static sprite-sheet dancers across a sequence of any moves:
Before:
before.mp4
After:
2025-10-28.15-30-27.2025-10-28.15_31_02.mp4