feat(sitemap): support root-level sitemap fallback for dynamic routes#19
Open
mateussilva92 wants to merge 1 commit intocode-forge-io:mainfrom
Open
feat(sitemap): support root-level sitemap fallback for dynamic routes#19mateussilva92 wants to merge 1 commit intocode-forge-io:mainfrom
mateussilva92 wants to merge 1 commit intocode-forge-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Description
This PR enhances the Remix/React Router v7 sitemap generation by introducing a root handle fallback.
Previously, only route-level
handle.sitemapfunctions were supported. Now:handle.sitemap, it will run for that route.root.tsxsitemap function will run as a fallback if it exists.This ensures consistent sitemap generation across all routes and reduces duplication for shared logic like multilingual alternates.
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
This was tested locally directly on a React Router v7 project that I'm currently working on. I defined a
handlefunction that returned a object with asitemapfunction on myroot.tsxand then checked the sitemap generated.Reviewer checklist
Mark everything that needs to be checked before merging the PR.
Screenshots (if appropriate):
Questions (if appropriate):