-
Notifications
You must be signed in to change notification settings - Fork 15
feat(utils): add NodeJS profiler #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add explanation that sink determines output format (DevTools TraceEvent, OpenTelemetry, etc.) - Improve documentation clarity for flexible serialization capabilities - Fix duplicate imports in profiler unit test
- Replace method implementations with vi.fn() spy functions - Add vi import from vitest - Enables better testing with call tracking and assertions
|
View your CI Pipeline Execution ↗ for commit 9c03f7f
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit e451245 with previous commit 270b474. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 7 audits improved, 👎 6 audits regressed, 14 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
652 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit e451245 with previous commit 270b474. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 45 | 🟡 56 | |
| Code coverage | 🟢 95 | 🟢 95 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 6 audits improved, 👎 3 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🔴 45 | 🟡 56 | |
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 95 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Properties coverage | 🟥 27 undocumented properties | 🟥 23 undocumented properties | |
| JSDocs coverage | Classes coverage | 🟨 3 undocumented classes | 🟨 2 undocumented classes | |
| JSDocs coverage | Methods coverage | 🟨 13 undocumented methods | 🟨 9 undocumented methods | |
| JSDocs coverage | Variables coverage | 🟥 49 undocumented variables | 🟥 48 undocumented variables | |
| JSDocs coverage | Types coverage | 🟥 66 undocumented types | 🟥 65 undocumented types | |
| JSDocs coverage | Functions coverage | 🟥 239 undocumented functions | 🟥 239 undocumented functions | |
| Code coverage | Branch coverage | 🟩 91.8 % | 🟩 91.6 % | |
| Code coverage | Function coverage | 🟩 96.2 % | 🟩 96 % | |
| Code coverage | Line coverage | 🟩 97.8 % | 🟩 97.8 % |
435 other audits are unchanged.
13 other projects are unchanged.
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Related: #1197
This PR includes:
NodeJSProfilerclassNodeJSProfilerPerformanceObserverSink- add getStatus for better testing, more robust and memory friendly buffer logic