feat(neo-tui): real port of 8 legacy senpi features (Round 12)#16
Merged
Conversation
Oracle round 12 BLOCKED on the 'full Rust port' framing: too many legacy actions surfaced 'not yet wired' notes instead of real behavior. This round wires the highest-impact surface area: 1. Ctrl+T (`app.thinking.toggle`): chat::ChatViewOpts::thinking_visible now drives render_assistant_message. Hides both the summary line and the expanded body when false. 2. Ctrl+O (`app.tools.expand`): ChatViewOpts::tools_expanded now drives render_tool_card. Collapses tool body to one-line hint when false. Header rule still renders so the user can find the card. 3. Alt+S (`neo.sidebar.toggle`): new `sidebar_visible` field toggles the sidebar pane (gated by terminal width). 4. Alt+A (`neo.toggle_animations`): new `animations_enabled` field gates spinner-frame advancement + input focus-pulse. 5. Alt+C (`neo.compact`): new `Command::Compact` variant + `AppAction::CompactSession` fire backend compaction. 6. Model picker (`neo.model.set:<id>`): new `provider_for_model_id` heuristic + `AppAction::SetModel` variant fire `Command::SetModel` end-to-end. 7. Ctrl+G (`app.editor.external`): new `AppAction::ExternalEditorLaunch` + `TerminalEventOutcome::ExternalEditor` + `run_external_editor` helper. Suspends TUI, edits buffer in $VISUAL/$EDITOR/vi, reads back, restores TUI. 8. Alt+Up (`app.message.dequeue`): new `ChatState.queued_messages` field tracked from `RpcEvent::QueueUpdate` events. Pops most recent into input buffer on chord. Test count: 333 -> 341 passing. `cargo fmt --check`, `cargo clippy --all-targets -- -D warnings` (with one targeted `struct_excessive_bools` allow on App documenting why), and `npm run check` (898 files) all green. ADVERTISED_BUT_UNIMPLEMENTED_ACTIONS shrunk by 5 entries. Remaining ~29 entries cover the genuine follow-up surface (session tree / branching / models management / tree filters / image paste) which require sub-overlays + JSONL session parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oracle round 12 BLOCKED on the "full Rust port" framing — too many legacy actions surfaced "not yet wired" notes instead of real behavior. This PR wires 8 highest-impact features:
app.thinking.toggle):ChatViewOpts::thinking_visibledrivesrender_assistant_messageapp.tools.expand):ChatViewOpts::tools_expandeddrivesrender_tool_cardneo.sidebar.toggle): newApp.sidebar_visiblefieldneo.toggle_animations): newApp.animations_enabledfieldneo.compact): newCommand::Compact+AppAction::CompactSessionneo.model.set:<id>): newprovider_for_model_idheuristic +Command::SetModelend-to-endapp.editor.external): suspend TUI → spawn$VISUAL/$EDITOR/vi→ read back → restore TUIapp.message.dequeue): newChatState.queued_messagestracked fromQueueUpdate, pops most recent to bufferTest count: 333 → 341.
cargo clippy --all-targets -- -D warnings,cargo fmt --check,npm run check(898 files) all green.ADVERTISED_BUT_UNIMPLEMENTED_ACTIONSshrunk by 5. Remaining ~29 entries cover session tree / branching / models management / tree filters / image paste — they require sub-overlays + JSONL session parsing, tracked as a separate feature pack.Summary by cubic
Ports eight legacy
senpicommands to real behavior inneo-tui, replacing “not yet wired” notes with working UI and RPCs. Shrinks the unimplemented-action list by 5; tests now 341 and checks pass.ChatViewOpts.thinking_visible.ChatViewOpts.tools_expanded.App.sidebar_visible(width-gated).App.animations_enabled(freezes spinner and focus pulse).Command::Compactto compact the session.neo.model.set:<id>): fireCommand::SetModel; provider inferred byprovider_for_model_id(claude→anthropic, gpt→openai, kimi→kimi-for-coding, glm→opencode-zen, deepseek→deepseek, gemini→google).$VISUAL/$EDITOR/vi, read back into input, restore TUI.ChatState.queued_messagesfromRpcEvent::QueueUpdate.Written for commit 6ee9e08. Summary will update on new commits. Review in cubic