[pull] main from TryGhost:main#1049
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/PLA-17/ ## Summary - Replaced yarn v1 with pnpm as the monorepo package manager - Using `shamefully-hoist=true` to match yarn v1's flat `node_modules` layout for compatibility - All scripts, CI workflows, Docker configs, and documentation updated - Fixed phantom dependencies exposed by pnpm's stricter resolution This is an initial set of changes where we're leveraging a blank `shamefullyHoistDependencies`. I'll follow up with a few additional PRs that are more incremental, with a smaller blast radius, in order to more fully leverage `pnpm` in this repo. Already, though, we're seeing dramatic speedups. I've already bumped Ghost-CLI to `1.29.1.` which is compatible with `pnpm`. The community Docker container will need an update to enable core pack for this version and I'll coordinate that separately. With a clean Docker container we're already seeing dramatic speedups: ┌───────────┬─────────┬──────┬─────────┐ │ Step │ yarn v1 │ pnpm │ Speedup │ ├───────────┼─────────┼──────┼─────────┤ │ git clone │ 15s │ 16s │ ~same │ ├───────────┼─────────┼──────┼─────────┤ │ setup │ 146s │ 22s │ 6.6x │ ├───────────┼─────────┼──────┼─────────┤ │ Total │ 161s │ 39s │ 4.1x │ └───────────┴─────────┴──────┴─────────┘
ref f186b6a - fixed `pnpm run nx build` → `pnpm nx build` in the publish workflow — `pnpm run nx` looks for a nonexistent `nx` script in package.json, while `pnpm nx` correctly invokes the binary from node_modules The `publish_packages` job now runs on PRs too — on PRs it builds each package to verify the publish pipeline works; on main it continues to do the full version check → build → publish → CDN purge flow. This is to prevent failures on merge to main, like we had in the above commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )