[pull] main from TryGhost:main#1052
Merged
Merged
Conversation
…pps (#27347) no ref - Add `exports` field to posts, stats, and activitypub package.json with subpath exports - Create `src/api.ts` in posts and stats as the public cross-package API - Update admin to import from `@tryghost/posts/api`, `@tryghost/stats/api`, `@tryghost/activitypub/api` instead of reaching into `src/` Admin was importing directly into other workspace packages' `src/` directories (`@tryghost/posts/src/providers/...`). This is a cross-package boundary violation — it bypasses the package's public API and couples admin to internal file structure; ultimately not a great pattern, and this makes it a bit easier when we want to combine these apps. This is also prep work for `pnpm deploy` with `injectWorkspacePackages=true`. The subpath exports currently point at source files (`./src/api.ts`), which works for normal workspace resolution (pnpm symlinks to the full directory). When `injectWorkspacePackages` is enabled, the `files` field in each package will need to include `src/` (or the exports will need to point at built outputs in `dist/`). That change belongs in the pnpm deploy PR.
no issue - add nrwl/nx-set-shas github action to set HEAD/BASE commit SHAs on main branch CI runs. - simplify unit test job by adding build as a dependent target for test:unit scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )