[pull] main from TryGhost:main#1139
Merged
Merged
Conversation
…iption_notifications (#27863) closes https://linear.app/ghost/issue/BER-3655 closes https://linear.app/ghost/issue/BER-3554 Renames the `users.gift_subscription_purchase_notification` column (added in v6.28) to `users.gift_subscription_notifications`. In #27769, we updated the email-preference toggle for gift subscriptions to enable/disable both gift **purchases** and gift **redemptions** email notifications. Therefore, the `_purchase_` segment of the column name is no longer correct. ### Implementation notes 1. This PR contains both a database migration and related code changes, which does not satisfy our general requirements for database migrations (see checklist below). However, we are renaming a database column in this migration, therefore we don't really have a choice. If we did commit A) renames column, and commit B) changes code, we’d have a broken state between commit A and B. 2. On Ghost (Pro), Admin changes are deployed prior to server changes. This PR contains both Admin and server changes. There will be a point in time where the Admin changes are deployed, but the related database migration has not run yet. During that time, toggling the email preference on gift subscriptions will be broken. We're accepting this limitation given that gift subscriptions are still behind a feature flag and the feature has not been enabled yet on any production sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )