[pull] main from microsoft:main#1283
Merged
Merged
Conversation
* Forward session sync setting to copilot-sdk via remote flag When chat.sessionSync.enabled is true, pass remote: true in CopilotClientOptions so the SDK exports sessions to cloud storage. - Add AgentHostSessionSyncEnabledConfigKey to platformRootSchema - Forward setting from renderer via RootConfigChanged action - Read config in CopilotAgent and pass as remote in client options - Restart CLI client on setting change when no active sessions The remote field uses an intersection type for forward-compat until the SDK bump in #317241 lands (CopilotClientOptions natively gains it). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address review: handle async errors and init _lastSessionSyncEnabled - Add .catch() to _restartClientIfSessionSyncChanged() call to prevent unhandled promise rejections - Initialize _lastSessionSyncEnabled from config eagerly to avoid spurious client restarts on unrelated root config changes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enhance feedback widget behavior: implement auto-hide logic and preserve state when text is present
Fix #317643 The shared-process `UnusedWorkspaceStorageDataCleaner` was deleting the agents window's workspace storage folder (chat sessions, edits, images, test results, etc.) when the agents window was not open within ~30s of Code launching. The agents window uses a synthetic workspace identifier computed in the renderer via the browser-side `getWorkspaceIdentifier` (a short hex hash). The on-disk storage folder is named with this short id, but none of the cleaner's preservation checks matched it: - length check expects 32-char MD5 ids - ext-dev id check does not match - main-side `window.workspace.id` is the 32-char MD5 (mismatch) - `isUsed` only true while the agents window is actually open Changes: - Move `getWorkspaceIdentifier`/`getSingleFolderWorkspaceIdentifier` from `workbench/services/workspaces/browser/workspaces.ts` to `platform/workspaces/common/workspaceIdentifier.ts` so the shared-process cleaner can import them without layer violations. - Promote `IEnvironmentService.agentSessionsWorkspace` to required and add a browser-side implementation in `BrowserWorkbenchEnvironmentService` (stub in `StandaloneEnvironmentService`). - In the cleaner, preserve the folder matching `getWorkspaceIdentifier(env.agentSessionsWorkspace).id`. - Add a unit test that asserts the agents window folder survives cleanup while other empty-workspace folders are removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* promptFileContributions are missing sessionTypes * update
This is easily isolated in a contrib, simplifying the core terminal further
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )