[pull] main from microsoft:main#1287
Merged
Merged
Conversation
…rogress part (#318053) The legacy AgentHostEditingSession (844 LOC) only existed to translate completed tool-call file edits into a markdownContent/codeblockUri/textEdit cluster that CollapsedCodeBlock would then re-derive into a diff pill by asking the editing session for stats it had just been handed. The agent host protocol already exposes FileEdit.diff and before/after content URIs up-front, so cut out the round-trip: - New IChatExternalEdit progress part carries uri, editKind, originalUri, beforeContentUri, afterContentUri, and diff stats directly. - stateToProgressAdapter.completedToolCallToEditParts emits one IChatExternalEdit per FileEdit, wrapping every URI via toAgentHostUri so remote sessions resolve through the agent host file system provider. - Extract ChatEditPillElement base class from CollapsedCodeBlock — same DOM / styling, no editing-session coupling. New ChatExternalEditContentPart extends it and renders a static pill from the progress data. - ChatThinkingContentPart.appendItem now accepts IChatExternalEdit metadata directly (via the new ChatThinkingItemMetadata alias); it derives the title (Created/Deleted/Renamed/Edited <filename>) and the pencil icon without any synthesized markdown. Diff stats bubble up through onDidChangeDiff (fired on a microtask so subscribers attach first). - AgentHostSnapshotController (~330 LOC) replaces the legacy editing session: implements IChatEditingSession but only restoreSnapshot, requestDisablement, and snapshot URIs do real work. Everything else is a no-op so the chat-level Restore-to-checkpoint UI keeps working without dragging in the full diff pipeline. - ChatChangesSummaryPart is intentionally skipped for agent host responses — per-file pills already convey the change counts inline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Anthropic returns 400 (`messages.N.content.M: 'thinking' or 'redacted_thinking' blocks in the latest assistant message cannot be modified` and `Invalid 'data' in 'redacted_thinking' block`) when historical thinking/redacted_thinking blocks have lost or rotated their signature/data on round-trip — most visibly on claude-haiku-4.5 / claude-sonnet-4.6 in agent mode (~18k hits/day). The Anthropic Extended Thinking docs explicitly allow omitting thinking blocks from prior assistant role turns, and on Opus 4.5+/Sonnet 4.6+ omission is neutral for quality. Pre-#315406 (≤ 0.47) we already did this; #315406 added 'messages' to apiSupportsHistoricalThinking, which is what flipped the behavior. Reverts only the 'messages' membership; 'responses' (OpenAI Responses API) still needs to round-trip encrypted reasoning blocks across turns and is unaffected. Flips the matching unit test and renames model fixtures to claude-haiku-4-5 (the dominant in-prod offender).
…317213) * wip * filter out files outside of workspace from subagent response * revert settings.json * address code review comments * retrigger gh check
* Exclude MXC SDK catalog manifests from Authenticode checks * Exclude MXC executables from VersionInfo sanity check
…eation time (#317905) * Enhance telemetry in Copilot CLI chat session: include isolation mode and worktree status * Add session tracking for Copilot CLI: implement turn count and creation time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )