[pull] main from microsoft:main#1289
Merged
Merged
Conversation
…#318092) * Fix BYOK regression for non-OAuth Copilot token pathways Introduce hasCopilotTokenSource on IAuthenticationService, defaulted to !!anyGitHubSession in BaseAuthenticationService and overridden to true in StaticGitHubAuthenticationService (proxy/HMAC, eval harness). Replace PR-introduced anyGitHubSession guards added in #317428 at sites that gate on 'can we mint a Copilot token?' so the eval proxy pathway is no longer short-circuited: - languageModelAccess._getToken - authentication.contribution.waitForChatEnabled - copilotCli (3 sites) - remoteEmbeddingsComputer Group-B sites that intentionally gate on a real signed-in GitHub user (conversationFeature search/intent provider registration, byokUtilityModel notification) keep using anyGitHubSession. * PR feedback: clarify log message; fall back to empty embeddings in proxy scenarios - Update languageModelAccess log to say 'Copilot token source' (matches the new gate). - In remoteEmbeddingsComputer, return empty embeddings instead of throwing when the Dotcom path lacks a GitHub access token (proxy/HMAC eval harness), matching the rest of the function's empty-fallback behavior.
The sidebar in the Agents app sometimes showed "Created 0 todos" or similar misleading text under a session title. This came from the `manage_todo_list` tool's `pastTenseMessage` being surfaced via `getInProgressSessionDescription` even though the tool invocation was already marked as `ToolInvocationPresentation.Hidden` (so it wasn't shown in the chat view at all). - `getInProgressSessionDescription`: skip tool invocations that are effectively hidden, so the sidebar falls through to the previous meaningful part instead of leaking text from a hidden tool call. - `manageTodoListTool.generatePastTenseMessage`: don't generate "Created 0 todos" for a no-op write (no current and no new todos); fall through to the default "Updated todo list" message. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When tool search is active, built-in tools were being collapsed into virtual groups that tool search never surfaces, making non-deferred tools (e.g. askQuestions) uncallable. Detect tool_search from the full tool list and skip built-in grouping in that case. Fixes #316779.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )