Skip to content

[pull] main from microsoft:main#1302

Merged
pull[bot] merged 5 commits into
code:mainfrom
microsoft:main
May 27, 2026
Merged

[pull] main from microsoft:main#1302
pull[bot] merged 5 commits into
code:mainfrom
microsoft:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented May 27, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

deepak1556 and others added 5 commits May 27, 2026 14:57
* feat: update to Electron v42

* chore: drop support for arm 32-bit server

* chore: update types/node to v24.x

* chore: temporarily lock the target version for build/

* chore: update v8-source-location.patch

* chore: fix clippy

* chore: cleanup armhf server ci config

* fix: broken lock file

* fix: c++ version requirement for sysroot builds

* fix: msvc compilation of native modules

* fix: handle rejections for fire-and-forget loadurl

* fix: windows build

* ci: fix teardown of daemon process on windows

```
2026-05-15T20:55:09.7717127Z Assertion failed: !(handle->flags & UV_HANDLE_CLOSING), file src\win\async.c, line 76
```

* chore: update deb and rpm dependencies

* chore: update version info

* spec: improve reliablity of offscreencanvas tests

* spec: retry EPERM failures on teardown

* chore: update x86_64 rpm deps

* ci: exclude server binskim for armhf

* temp: bump distro

* test: ignore deprecation warnings treated as errors

* chore: update lockfile

* fix: externalize electron from auth extension bundles

 Error: Cannot find module 'c:\Users\cloudtest\AppData\Local\Temp\vscode-sanityQvCaze\vscode-server-win32-x64-web\extensions\github-authentication\dist\install.js'
     at Module._resolveFilename (node:internal/modules/cjs/loader:1476:15)
     at wrapResolveFilename (node:internal/modules/cjs/loader:1049:27)
     at defaultResolveImplForCJSLoading (node:internal/modules/cjs/loader:1073:10)
     at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1094:12)
     at Module._load (node:internal/modules/cjs/loader:1262:25)
     at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
     at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
     at node:internal/main/run_main_module:33:47 {
   code: 'MODULE_NOT_FOUND',
   requireStack: []
 }

 Node.js v24.15.0

* test: make wsl sanity tests reliable

* chore: bump electron@42.1.0

* temp: bump distro

* chore: bump electron@42.2.0

* chore: bump distro

* chore: update debian dependencies

* Revert "test: make wsl sanity tests reliable"

This reverts commit b3f2b63.

* test: do not fail for deprecation warnings

* chore: patch node24 server binary for wsl1

* chore: address review feedback

* chore: revert global navigation error handler in browserview

* chore: bump distro
* sessions: remember agent-host session config picks

Remember all string session-config picks for agent-host new sessions in profile storage, seed new sessions from those remembered values, and preserve legacy isolation-key compatibility.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* sessions: harden remembered session config seeding

Address CCR feedback by sanitizing remembered config keys, using prototype-safe maps, enforcing autoApprove policy/feature normalization for remembered values, and expanding provider tests for remembered storage/seeding/fallback behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* sessions: prefer permissions default for autoApprove

Make chat.permissions.default take precedence over remembered autoApprove values when seeding new agent-host sessions, while keeping policy/feature normalization and remembered-value hardening.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* sessions: remove unused legacy isolation storage key

The legacy key was never shipped so there is no backward-compat need. All remembered config values now go through the single STORAGE_KEY_REMEMBERED_SESSION_CONFIG_VALUES map.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: align test expectations with mock resolveSessionConfig behavior

The mock replaces initial config values after resolve, so seededImmediately reads undefined for autoApprove. The forwardedToAgentHost assertion proves the seed was correct.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: stabilize autoApprove precedence test

Assert on forwardedToAgentHost only — it deterministically proves the seed was correct regardless of async resolve timing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… init (#318504)

If CopilotAgentSession is disposed while initializeSession() is awaiting
the wrapper factory, the subsequent _subscribeToEvents() /
_subscribeForLogging() calls would invoke _register on an already-
disposed DisposableStore, producing 'added object will be leaked'
warnings and leaking the SDK session wrapper.

After the factory resolves, check whether the store has been disposed;
if so, dispose the freshly-created wrapper and throw CancellationError
so callers (_materializeProvisional / _resumeSession) treat it as a
cancellation rather than producing a half-initialized session.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pull pull Bot locked and limited conversation to collaborators May 27, 2026
@pull pull Bot added the ⤵️ pull label May 27, 2026
@pull pull Bot merged commit 4a5c2b8 into code:main May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants