Conversation
… with upstream defaults (#46221) ## Why When we're building REA and RNWorklets we're missing some flag default values. This came up here: #Fixes #46209 ## How Added default values for flags in precompile config: RNWorklets: - `FETCH_PREVIEW_ENABLED` = false REA: - `USE_SYNCHRONIZABLE_FOR_MUTABLES` = true - `USE_COMMIT_HOOK_ONLY_FOR_REACT_COMMITS` = true - `FORCE_REACT_RENDER_FOR_SETTLED_ANIMATIONS` = true Also verified that SDK-55 isn't affected by this issue since it has other versions of these libs. ## Test-plan ✅ Prebuild REA and RNWorklets with new flags. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )