Conversation
# Why We support React Navigation now as well. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - add a page for react navigation integration - group it and the expo router integration in an integrations foldet <!-- How did you build this feature or fix this bug and why? --> # Test Plan See `/eas/observe/integrations/react-navigation/` in the PR preview <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Douglas Lowder <douglowder@mac.com> Co-authored-by: Aman Mittal <amandeepmittal@live.com> Co-authored-by: Jakub Tkacz <32908614+Ubax@users.noreply.github.com>
…callbacks (#46342) # Why Resolves - #46269 When using worklet inside of `useEffectEvent` we get a non worklet callback. So the flicker issue still happens, it was hard to reproduce on simulator. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How Replace `useEffectEvent` with `useCallback` <!-- How did you build this feature or fix this bug and why? --> # Test Plan Tested the example on real device. It does not flicker after the change <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Co-authored-by: Kadi Kraman <kadi@expo.io>
# Why Similar to #44359 and #45992, async file IO makes the UI more responsive # How 1. Replace `FileHandle.readBytes()` and `FileHandle.writeBytes()` with async definitions in both TS and native code 2. Update downstream calls 3. Update test cases # Test Plan 1. `CI=1 pnpm build`, `pnpm lint --fix` and `CI=1 pnpm test` passed in `packages/expo-file-system` <details><summary>Output</summary> ``` > expo-module test PASS Android src/__tests__/FSNetworkTasks-test.native.ts PASS Android src/__tests__/FileSystem-test.native.ts PASS Node src/__tests__/FileSystemWatcher-test.ts PASS Web src/__tests__/FileSystemWatcher-test.ts PASS Android src/__tests__/FileSystemWatcher-test.ts PASS Android src/legacy/__tests__/FileSystem-test.native.ts PASS iOS src/__tests__/FileSystem-test.native.ts PASS iOS src/__tests__/FSNetworkTasks-test.native.ts PASS iOS src/__tests__/FileSystemWatcher-test.ts PASS iOS src/legacy/__tests__/FileSystem-test.native.ts Test Suites: 10 passed, 10 total Tests: 14 skipped, 196 passed, 210 total Snapshots: 0 total Time: 2.021 s Ran all test suites in 4 projects. ``` </details> 2. `pnpm et check expo-file-system` passed in project root (tested on 91dbfb4) <details><summary>Output</summary> ``` 🛠 Rebuilding expotools ✨ Successfully built expotools 🔍 Checking expo-file-system package 🏃♀️ Running pnpm run clean 🏃♀️ Running pnpm run build 🏃♀️ Running pnpm run test --watch false --passWithNoTests 🏃♀️ Running pnpm run lint --max-warnings 0 ✨ expo-file-system checks passed 🔌 Checking expo-file-system plugin 🏃♀️ Running pnpm run clean plugin 🏃♀️ Running pnpm run build plugin 🏃♀️ Running pnpm run test plugin --watch false --passWithNoTests 🏃♀️ Running pnpm run lint plugin --max-warnings 0 ✨ expo-file-system checks passed 🏁 All packages passed. ``` </details> 3. `pnpm ios` in `apps/bare-expo` then running tests manually (passed, on 91dbfb4) <details><summary>Screenshot</summary> <img width="100%" height="100%" alt="image" src="https://github.com/user-attachments/assets/e61e7f89-c347-4a03-a7f4-c242cb6b1bfd" /> </details> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )