fix: Make type optional.#17
Merged
Merged
Conversation
This is the most honest approach given out data set and users' conventions. closes #16
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the type field optional in the Categories type to better reflect the actual data structure and user conventions in the codebase.
Key changes:
- Changed
type: Typetotype?: Typein theCategoriestype definition
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@copilot do another review. |
|
@tim-rohrer I've opened a new pull request, #18, to work on those changes. Once the pull request is ready, I'll request review from you. |
SIA-WEBSUP
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most honest approach given our data set and users' conventions.
Should probably confirm OIAA Direct checks for non existence of this key.
closes #16