feat: cache member attending event IDs to eliminate N+1 queries#2501
Open
mroderick wants to merge 1 commit intocodebar:masterfrom
Open
feat: cache member attending event IDs to eliminate N+1 queries#2501mroderick wants to merge 1 commit intocodebar:masterfrom
mroderick wants to merge 1 commit intocodebar:masterfrom
Conversation
Motivation: The events and meetings index pages were making N+1 queries when checking if a logged-in member was attending each event. Each call to @user.attending?(event) triggered a database query. Analysis: - Before: 40 queries for 40 events - After: 3 queries (one each for invitations, workshop_invitations, meeting_invitations) - The cache returns a Set of all event IDs where the member has an accepted invitation, making subsequent lookups O(1) Ruby operations. The cache is invalidated when an invitation's attending status changes via after_save callbacks on Invitation, WorkshopInvitation, and MeetingInvitation models. This ensures the cache stays fresh on the next request after RSVP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attending_event_idsmethod to Member model that caches all event/workshop/meeting IDs where member has accepted invitationMotivation
The events and meetings index pages were making N+1 queries when checking if a logged-in member was attending each event.
Analysis
Test Plan