fix: eager load sponsors and sponsorships in EventsController#2502
Open
mroderick wants to merge 1 commit intocodebar:masterfrom
Open
fix: eager load sponsors and sponsorships in EventsController#2502mroderick wants to merge 1 commit intocodebar:masterfrom
mroderick wants to merge 1 commit intocodebar:masterfrom
Conversation
Motivation: Bullet was reporting N+1 queries when rendering the events index page. The view calls event.sponsors which requires the sponsorships join table to be eager loaded. Analysis: - Before: N+1 query per event for sponsors - After: Single query with LEFT OUTER JOIN on sponsorships This applies to both upcoming and past events queries in the index action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:sponsorshipsto eager loading in Event queries:sponsorsto eager loading in Workshop queriesMotivation
Bullet was reporting N+1 queries when rendering the events index page. The view calls
event.sponsorswhich requires the sponsorships join table to be eager loaded.Analysis
Test Plan