Skip to content

⚡️ Speed up method BooleanValue.estimateSize by 25% #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method BooleanValue.estimateSize by 25% #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion client/src/com/aerospike/client/Value.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,6 +1139,9 @@ public long toLong() {
* Boolean value.
*/
public static final class BooleanValue extends Value {
public static final BooleanValue TRUE = new BooleanValue(true);
public static final BooleanValue FALSE = new BooleanValue(false);

private final boolean value;

public BooleanValue(boolean value) {
Expand Down Expand Up @@ -1207,7 +1210,21 @@ public int toInteger() {
public long toLong() {
return value? 1L : 0L;
}
}

/**
* Return the primitive boolean held by this Value.
*/
public boolean getValue() {
return value;
}
/**
* Factory method that returns a cached instance for true/false.
* This improves performance by reducing object allocations in hot paths.
*/
public static BooleanValue of(boolean v) {
return v ? TRUE : FALSE;
}
}

/**
* Boolean value that converts to integer when sending a bin to the server.
Expand Down