Skip to content

⚡️ Speed up function discover_functions_from_source by 12% in PR #1199 (omni-java) #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up function discover_functions_from_source by 12% in PR #1199 (omni-java) #1293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions codeflash/languages/java/discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from codeflash.languages.base import FunctionFilterCriteria
from codeflash.languages.java.parser import JavaAnalyzer, JavaMethodNode, get_java_analyzer
from codeflash.models.function_types import FunctionParent
import fnmatch

if TYPE_CHECKING:
pass
Expand Down Expand Up @@ -81,6 +82,8 @@ def discover_functions_from_source(

functions: list[FunctionToOptimize] = []

default_file_path = file_path or Path("unknown.java")

for method in methods:
# Apply filters
if not _should_include_method(method, criteria, source, analyzer):
Expand All @@ -94,7 +97,7 @@ def discover_functions_from_source(
functions.append(
FunctionToOptimize(
function_name=method.name,
file_path=file_path or Path("unknown.java"),
file_path=default_file_path,
starting_line=method.start_line,
ending_line=method.end_line,
starting_col=method.start_col,
Expand Down Expand Up @@ -140,16 +143,20 @@ def _should_include_method(
if method.name == method.class_name:
return False

# Check include patterns

# Check include_methods - in Java, all functions in classes are methods
if not criteria.include_methods and method.class_name is not None:
return False

# Check include patterns
if criteria.include_patterns:
import fnmatch

if not any(fnmatch.fnmatch(method.name, pattern) for pattern in criteria.include_patterns):
return False

# Check exclude patterns
if criteria.exclude_patterns:
import fnmatch

if any(fnmatch.fnmatch(method.name, pattern) for pattern in criteria.exclude_patterns):
return False
Expand All @@ -162,16 +169,14 @@ def _should_include_method(
if not analyzer.has_return_statement(method, source):
return False

# Check include_methods - in Java, all functions in classes are methods
if not criteria.include_methods and method.class_name is not None:
return False

# Check line count
method_lines = method.end_line - method.start_line + 1
if criteria.min_lines is not None and method_lines < criteria.min_lines:
return False
if criteria.max_lines is not None and method_lines > criteria.max_lines:
return False
if criteria.min_lines is not None or criteria.max_lines is not None:
method_lines = method.end_line - method.start_line + 1
if criteria.min_lines is not None and method_lines < criteria.min_lines:
return False
if criteria.max_lines is not None and method_lines > criteria.max_lines:
return False


return True

Expand Down
Loading