Skip to content

⚡️ Speed up function _filter_new_declarations by 12% in PR #1546 (follow-up-reference-graph) #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 2 commits into from
Closed

⚡️ Speed up function _filter_new_declarations by 12% in PR #1546 (follow-up-reference-graph) #1548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8b23a
Optimize _filter_new_declarations
codeflash-ai[bot] Feb 19, 2026
0250d59
style: auto-fix linting issues
github-actions[bot] Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions codeflash/languages/javascript/code_replacer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from __future__ import annotations

from operator import attrgetter
from typing import TYPE_CHECKING

from codeflash.cli_cmds.console import logger
Expand Down Expand Up @@ -103,9 +104,7 @@ def _filter_new_declarations(optimized_declarations: list, existing_names: set[s
seen_sources: set[str] = set()

# Sort by line number to maintain order from optimized code
sorted_declarations = sorted(optimized_declarations, key=lambda d: d.start_line)

for decl in sorted_declarations:
for decl in sorted(optimized_declarations, key=attrgetter("start_line")):
if decl.name not in existing_names and decl.source_code not in seen_sources:
new_declarations.append(decl)
seen_sources.add(decl.source_code)
Expand Down
Loading