Skip to content

⚡️ Speed up method JavaScriptSupport._build_runtime_map by 87% in PR #1561 (add/support_react) #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claude merged 2 commits into from
Feb 20, 2026
Merged

⚡️ Speed up method JavaScriptSupport._build_runtime_map by 87% in PR #1561 (add/support_react) #1612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d93dd8
Optimize JavaScriptSupport._build_runtime_map
codeflash-ai[bot] Feb 20, 2026
b0afcce
style: auto-fix linting issues
github-actions[bot] Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions codeflash/languages/javascript/support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1943,6 +1943,9 @@ def _build_runtime_map(
from codeflash.languages.javascript.edit_tests import resolve_js_test_module_path

unique_inv_ids: dict[str, int] = {}
# Cache resolved path strings per module path to avoid repeated filesystem resolves
_resolved_path_cache: dict[str, str] = {}

for inv_id, runtimes in inv_id_runtimes.items():
test_qualified_name = (
inv_id.test_class_name + "." + inv_id.test_function_name # type: ignore[operator]
Expand All @@ -1951,20 +1954,28 @@ def _build_runtime_map(
)
if not test_qualified_name:
continue
abs_path = resolve_js_test_module_path(inv_id.test_module_path, tests_project_rootdir)

abs_path_str = str(abs_path.resolve().with_suffix(""))
module_path_key = inv_id.test_module_path
abs_path_str = _resolved_path_cache.get(module_path_key)
if abs_path_str is None:
abs_path = resolve_js_test_module_path(module_path_key, tests_project_rootdir)
try:
abs_path_str = str(abs_path.resolve().with_suffix(""))
except Exception:
# Fallback in case resolve() fails for any reason; preserve behavior
abs_path_str = str(abs_path.with_suffix(""))
_resolved_path_cache[module_path_key] = abs_path_str

if "__unit_test_" not in abs_path_str and "__perf_test_" not in abs_path_str:
continue

key = test_qualified_name + "#" + abs_path_str
iteration_id = inv_id.iteration_id or ""
parts = iteration_id.split("_").__len__()
cur_invid = iteration_id.split("_")[0] if parts < 3 else "_".join(iteration_id.split("_")[:-1])
parts = iteration_id.split("_")
parts_len = len(parts)
cur_invid = parts[0] if parts_len < 3 else "_".join(parts[:-1])
match_key = key + "#" + cur_invid
if match_key not in unique_inv_ids:
unique_inv_ids[match_key] = 0
unique_inv_ids[match_key] += min(runtimes)
unique_inv_ids[match_key] = unique_inv_ids.get(match_key, 0) + min(runtimes)
return unique_inv_ids

# === Test Result Comparison ===
Expand Down