fix: add types.UnionType support to comparator#1617
Open
aseembits93 wants to merge 1 commit intomainfrom
Open
Conversation
The comparator did not recognize `types.UnionType` (Python 3.10+ `X | Y` syntax), causing it to fall through to "Unknown comparator input type". Conditionally include it in the equality-checked types tuple. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
PR Review SummaryPrek Checks✅ All checks passed (ruff check, ruff format) — no issues found. Mypy✅ No new mypy errors introduced by this PR. All reported errors are pre-existing on Code Review✅ No critical bugs, security vulnerabilities, or breaking API changes found. Notes:
Test Coverage
Last updated: 2026-02-20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
types.UnionType(the type produced by Python 3.10+X | Yunion syntax), causing it to log "Unknown comparator input type" and returnFalsefor valid equal unions.types.UnionTypeto the equality-checked types tuple (guarded bygetattrfor Python 3.9 compatibility).Test plan
TestUnionTypetests passcomparator.pygetattr)🤖 Generated with Claude Code